[PATCH] D103539: RISCV: adjust handling of relocation emission for RISCV

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd marked 4 inline comments as done.
compnerd added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.h:98
+  bool relaxDwarfLineAddr(MCDwarfLineAddrFragment &DF, MCAsmLayout &Layout,
+                          bool &WasRelaxed) const override;
+  bool relaxDwarfCFA(MCDwarfCallFrameFragment &DF, MCAsmLayout &Layout,
----------------
MaskRay wrote:
> s/WasRelaxed/Relaxed/ to be consistent with the impl
Changed the implementation instead.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVFixupKinds.h:84
   fixup_riscv_align,
+  // fixup_riscv_set_8 - 8-bit fixup corresponding to R_RISCV_SET8 for local
+  // label assignment.
----------------
MaskRay wrote:
> https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments
> 
> "Don’t duplicate function or class name at the beginning of the comment. "
> 
> Just ignore some other comments which violate this rule.
*shrug* sure, though I think that consistency is better than following the rules in this case (and is in the developer guidelines for LLVM IIRC).  However, I don't feel strongly enough to bother arguing ... so changed.  Also the comment leader doesn't seem like doxygen will heed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103539/new/

https://reviews.llvm.org/D103539