[PATCH] D104149: [MCA] Adding the CustomBehaviour class to llvm-mca

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D104149#2821977 <https://reviews.llvm.org/D104149#2821977>, @foad wrote:

>> Going back to the AMDGPU changes (sorry if I reopen the discussion).
>> I noticed that @foad has committed a sequence of patches aiming at improving llvm-mca simulation (thanks @foad !).
>> Do you know if in future we will still need a CustomBehaviour class for AMDGPU?
>
> I think we will still need the class. My patches only remove the need for AMDGPUCustomBehaviour::manuallySetWaitCntInfo with its long list of DS instruction opcodes.

Thanks for clarifying it.

In which case, the patch still LGTM.
Hopefully this time I won't need to revert it :-p

Cheers
-Andrea


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104149/new/

https://reviews.llvm.org/D104149