[PATCH] D104149: [MCA] Adding the CustomBehaviour class to llvm-mca

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

Thanks!
It must have been pretty annoying to have to address that issue. I am glad that you were able to find a workaround for it.

Going back to the AMDGPU changes (sorry if I reopen the discussion).
I noticed that @foad has committed a sequence of patches aiming at improving llvm-mca simulation (thanks @foad !).
Do you know if in future we will still need a CustomBehaviour class for AMDGPU?

In general, it think that it is valuable to have all your initial patch in tree.
People that want to add CustomBehaviour classes for their own targets would encounter the same problems that you had to solve with those macro definitions. Having an example that shows how to address that issue is very useful in general.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104149/new/

https://reviews.llvm.org/D104149