[PATCH] D104123: [llvm][AArch64] Handle arrays of struct properly (from IR)

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17223
+  SmallVector<EVT> ValueVTs;
+  ComputeValueVTs(*this, getTargetMachine().createDataLayout(), Ty, ValueVTs);
+  return is_splat(ValueVTs);
----------------
DavidSpickett wrote:
> efriedma wrote:
> > Actually, looking at this again, I'm not sure I like using createDataLayout() like this... it's kind of an expensive/unusual operation.  Can we pass down the datalayout from the callers?
> By expensive do you mean in that it creates a copy of the DataLayout object each time? (I thought maybe it reparses the layout string but it doesn't)
> 
> I will see about passing it down. (we have IsVarArg there already and only used by Arm)
Turned out it was simple to do anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104123/new/

https://reviews.llvm.org/D104123