[PATCH] D104102: [FuncSpec] Statistics

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/FunctionSpecialization/function-specialization-stats.ll:3
+
+; RUN: opt -stats -function-specialization -deadargelim -inline -S < %s 2>&1 | FileCheck %s
+
----------------
SjoerdMeijer wrote:
> fhahn wrote:
> > do we need to run those unrelated passes?
> Not necessarily, but it kind of nicely illustrates the possibilities with those "clean up" passes, the things function specialisation enables. 
> 
> Let me know what you prefer as I am of course happy to remove them.
> Not necessarily, but it kind of nicely illustrates the possibilities with those "clean up" passes, the things function specialisation enables. 
> 
> Let me know what you prefer as I am of course happy to remove them.

Usually we try to avoid having tests depend on different passes, to reduce churn when making changes to unrelated passes. While it is nice other stats improve, it’s independent of checking the function specialisation stats.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104102/new/

https://reviews.llvm.org/D104102