[PATCH] D104129: [CSSPGO] Report zero-count probe in profile instead of dangling probes.
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 15 23:20:25 PDT 2021
hoy added a comment.
In D104129#2821164 <https://reviews.llvm.org/D104129#2821164>, @wenlei wrote:
>> Be consistent with dwarf line number based profile.
>
> This is not accurate, see earlier comments. What i meant was not about "non-probe profile -> dwarf line number profile".
>
> Otherwise lgtm. Thanks.
It should be consistent with non-CS dwarf-based profile. CS dwarf-based profile doesn't have either zero or dangling reported, likely needs a fix. Is that what you meant?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104129/new/
https://reviews.llvm.org/D104129
More information about the llvm-commits
mailing list