[PATCH] D104346: [lld][MachO] Sort symbols in parallel in -map

[Xuanda Yang via Phabricator via llvm-commits]

TH3CHARLie added inline comments.


================
Comment at: lld/MachO/MapFile.cpp:55
   for (auto &it : ret)
-    llvm::stable_sort(it.second, [](Defined *a, Defined *b) {
-      return a->getVA() < b->getVA();
-    });
+    llvm::parallel::detail::parallel_sort(
+        it.second.begin(), it.second.end(), [](Defined *a, Defined *b) {
----------------
int3 wrote:
> I think this can just be `llvm::parallel_sort` (and with the `using namespace llvm` above, we don't even need the llvm::). Stuff under `detail` namespaces shouldn't be used directly -- they're implementation details
`parallel_sort` is not available in `llvm` namespace, `parallelSort` is. So maybe we should use `parallelSort` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104346/new/

https://reviews.llvm.org/D104346