[PATCH] D104035: [yaml2obj][obj2yaml] Support custom ELF section header string table name

[Xing GUO via Phabricator via llvm-commits]

Higuoxing accepted this revision.
Higuoxing added a comment.
This revision is now accepted and ready to land.

This patch looks great! I think the tests have covered everything.



================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:1926
+  // Build the section index, which adds sections to the section header string
+  // table first, so that we can finalise the section header string table.
   State.buildSectionIndex();
----------------
Nit: finalise -> finalize


================
Comment at: llvm/test/tools/obj2yaml/ELF/shstrtab.yaml:26
+
+## Show the case when the e_shstrndx value is 0 and the name is not ".shstrtab"
+## (the key should be set).
----------------
The value of `e_shstrndx` is `0xffff`, right?


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:520
             dyn_cast<ELFYAML::RawContentSection>(C.get())) {
+      // FIXME: The debugDebug* functions should take the content as stored in
+      // RawSec. Currently, they just use the last section with the matching
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104035/new/

https://reviews.llvm.org/D104035