[PATCH] D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 15:08:02 PDT 2021


aeubanks added a comment.

The patch looks mostly good, but I'm not sold on "op". Can we just use "p"?



================
Comment at: llvm/test/Verifier/opaque-ptr.ll:34
+
+declare void @llvm.lifetime.start.op(i64, ptr nocapture)
+declare void @llvm.lifetime.end.op(i64, ptr nocapture)
----------------
This is actually not the correct name, it should end with `op0`. We should add a CHECK line for the actual name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104272/new/

https://reviews.llvm.org/D104272



More information about the llvm-commits mailing list