[PATCH] D101074: [X86] Canonicalize LT/GT compares with constants to use LE/GE to reduce the number of EFLAGs reads. (PR48760)

Tue Jun 15 13:37:04 PDT 2021

lebedev.ri added a comment.

In D101074#2819404 <https://reviews.llvm.org/D101074#2819404>, @RKSimon wrote:

> Add SETLT/SETULT handling

Thanks.
I think this looks ok to me.
What about the regressions?

================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:42074
+    if (DecComparison == NegAddend) {
+      if (CC == X86::COND_AE && !Comparison.isNullValue()) {
+        Comparison = DecComparison;
----------------
`APInt::isMinValue()`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101074/new/

https://reviews.llvm.org/D101074