[PATCH] D104123: [llvm][AArch64] Handle arrays of struct properly (from IR)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 12:34:38 PDT 2021


efriedma requested changes to this revision.
efriedma added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17223
+  SmallVector<EVT> ValueVTs;
+  ComputeValueVTs(*this, getTargetMachine().createDataLayout(), Ty, ValueVTs);
+  return is_splat(ValueVTs);
----------------
Actually, looking at this again, I'm not sure I like using createDataLayout() like this... it's kind of an expensive/unusual operation.  Can we pass down the datalayout from the callers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104123/new/

https://reviews.llvm.org/D104123



More information about the llvm-commits mailing list