[PATCH] D103539: RISCV: adjust handling of relocation emission for RISCV

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 12:14:54 PDT 2021


jrtc27 added inline comments.


================
Comment at: llvm/test/MC/RISCV/hilo-constaddr-expr.s:4
-# RUN: llvm-mc -filetype=obj -triple=riscv32 -mattr=-relax %s 2>&1 \
-# RUN:     | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-INSTR
-# RUN: llvm-mc -filetype=obj -triple=riscv32 -mattr=-relax %s 2>&1 \
----------------
nickdesaulniers wrote:
> is it ok to drop the `llvm-objdump -d` test?
It was there to ensure that the assembled output was correct, but if it no longer assembles then you can't exactly test it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103539/new/

https://reviews.llvm.org/D103539



More information about the llvm-commits mailing list