[PATCH] D103992: [InstCombine / BuildLibCalls] Add parameter attributes from the prototype.

Tue Jun 15 11:46:16 PDT 2021

jonpa added a reviewer: efriedma.
jonpa added a subscriber: efriedma.
jonpa added a comment.

In D103992#2814596 <https://reviews.llvm.org/D103992#2814596>, @rnk wrote:

> I think the verifier is doing the right thing, I think it's a bug that `@llvm.memcpy` is carrying a `returned` attribute on the first argument. I'm not sure how that is happening, but whatever sets that up seems like a bug.

That was added by 8715e03 / https://reviews.llvm.org/D51092. I tried reverting that and got some test failures, whereof one in DeadStoreElimination, so it seems these are useful in some way...

@efriedma: You have any comment on how to proceed here (given you reviewed that revision)?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103992/new/

https://reviews.llvm.org/D103992