[PATCH] D104186: [llvm-objcopy] Make ihex writer similar to binary writer

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D104186#2816334 <https://reviews.llvm.org/D104186#2816334>, @jhenderson wrote:

> Just trying to follow the logic through. I think there is a potential behaviour change, which may be fine, but I just want to highlight it to see what others think (I have no use for IHEX myself, so don't feel like I can make a completely fair judgment either way). If I follow it correctly, if a writable section were not in a PT_LOAD segment, then previously it was skipped, if there was at least one writable section that was in such a segment, whereas now it won't be skipped. This is probably harmless (all such sections should have been placed in a segment anyway). Assuming I'm right, should we have a test-case to illustrate this behaviour change?

I think the coverage value is low. SHF_WRITE sections should have the SHF_ALLOC flag and be in a PT_LOAD segment. If not, that looks like an odd case. Not sure such case does arise for ihex users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104186/new/

https://reviews.llvm.org/D104186