[llvm] 7b969ef - [SimplifyCFG] avoid 'tmp' variables in test file; NFC

[David Blaikie via llvm-commits]

On Tue, Jun 15, 2021 at 3:34 AM Sanjay Patel <spatel at rotateright.com> wrote:

> Sorry, should've mentioned the reason: the auto-generated CHECK lines
> produced by the script at utils/update_test_checks.py can conflict with IR
> values named "tmp[0-9]+". The script warns at runtime about this, so this
> patch avoids that warning.
>
> More details here:
> https://llvm.org/PR45951
>

Ooh, so update checks names things for unnamed SSA values "TMP<ssa value
number>" but then also if the SSA value "tmpN" then it uses that directly,
uppercased, without any concern for it potentially overlapping with the
automatic naming of temporaries... yeah, that's inconvenient. Thanks for
the pointer!


>
> On Mon, Jun 14, 2021 at 9:20 PM David Blaikie <dblaikie at gmail.com> wrote:
>
>> Hmm, why is it important to avoid these?
>>
>> On Thu, Jun 10, 2021 at 2:04 PM Sanjay Patel via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>>
>>> Author: Sanjay Patel
>>> Date: 2021-06-10T17:04:23-04:00
>>> New Revision: 7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb
>>>
>>> URL:
>>> https://github.com/llvm/llvm-project/commit/7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb
>>> DIFF:
>>> https://github.com/llvm/llvm-project/commit/7b969ef8b4eb93d7a2be093b27280f12b8cd9ccb.diff
>>>
>>> LOG: [SimplifyCFG] avoid 'tmp' variables in test file; NFC
>>>
>>> Added:
>>>
>>>
>>> Modified:
>>>     llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll
>>>
>>> Removed:
>>>
>>>
>>>
>>>
>>> ################################################################################
>>> diff  --git a/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll
>>> b/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll
>>> index af647508ee65f..e9b52f49b961c 100644
>>> --- a/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll
>>> +++ b/llvm/test/Transforms/SimplifyCFG/two-entry-phi-return.ll
>>> @@ -4,21 +4,21 @@
>>>  define i1 @qux(i8* %m, i8* %n, i8* %o, i8* %p) nounwind  {
>>>  ; CHECK-LABEL: @qux(
>>>  ; CHECK-NEXT:  entry:
>>> -; CHECK-NEXT:    [[TMP7:%.*]] = icmp eq i8* %m, %n
>>> -; CHECK-NEXT:    [[TMP15:%.*]] = icmp eq i8* %o, %p
>>> -; CHECK-NEXT:    [[TMP15_:%.*]] = select i1 [[TMP7]], i1 [[TMP15]], i1
>>> false, !prof !0
>>> -; CHECK-NEXT:    ret i1 [[TMP15_]]
>>> +; CHECK-NEXT:    [[T7:%.*]] = icmp eq i8* [[M:%.*]], [[N:%.*]]
>>> +; CHECK-NEXT:    [[T15:%.*]] = icmp eq i8* [[O:%.*]], [[P:%.*]]
>>> +; CHECK-NEXT:    [[SPEC_SELECT:%.*]] = select i1 [[T7]], i1 [[T15]], i1
>>> false, !prof [[PROF0:![0-9]+]]
>>> +; CHECK-NEXT:    ret i1 [[SPEC_SELECT]]
>>>  ;
>>>  entry:
>>> -  %tmp7 = icmp eq i8* %m, %n
>>> -  br i1 %tmp7, label %bb, label %UnifiedReturnBlock, !prof !0
>>> +  %t7 = icmp eq i8* %m, %n
>>> +  br i1 %t7, label %bb, label %UnifiedReturnBlock, !prof !0
>>>
>>>  bb:
>>> -  %tmp15 = icmp eq i8* %o, %p
>>> +  %t15 = icmp eq i8* %o, %p
>>>    br label %UnifiedReturnBlock
>>>
>>>  UnifiedReturnBlock:
>>> -  %result = phi i1 [ 0, %entry ], [ %tmp15, %bb ]
>>> +  %result = phi i1 [ 0, %entry ], [ %t15, %bb ]
>>>    ret i1 %result
>>>
>>>  }
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210615/ffd0dff6/attachment.html>