[PATCH] D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kSubtarget.cpp:64
+  InstSelector.reset(createM68kInstructionSelector(
+      *static_cast<const M68kTargetMachine *>(&TM), *this, *RBI));
+}
----------------
sushmaunnibhavi wrote:
> myhsu wrote:
> > this casting seems to be redundant
> But when I remove that cast it causes build errors when I build M68k
In revision 351840, you changed the line into `createM68kInstructionSelector(&TM, ...)` but the first argument of `createM68kInstructionSelector` takes value of type `const M68kTargetMachine&` so of course it didn't compile. I think `createM68kInstructionSelector(TM, ...)` is the right way.

I recommend you to read the compile error message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819