[PATCH] D104028: [WIP] Use standard priority queue to order inlining

[Dawid Jurczak via Phabricator via llvm-commits]

yurai007 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:728
 
+class PriorityInlineOrder : public InlineOrder<std::pair<CallBase *, int>> {
+  using T = std::pair<CallBase *, int>;
----------------
nit: use 'final' to unlock devirtualization opportunity for overridden members.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:835
+  else
+    Calls.reset(new DefaultInlineOrder<std::pair<CallBase *, int>>());
+  assert(Calls != nullptr && "Expected an initialized InlineOrder");
----------------
nit: std::make_unique?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104028/new/

https://reviews.llvm.org/D104028