[PATCH] D103575: Allow signposts to take advantage of deferred string substitution

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

In D103575#2818340 <https://reviews.llvm.org/D103575#2818340>, @stella.stamenova wrote:

> The Windows buildbot does not like signposts:
>
> https://lab.llvm.org/buildbot/#/builders/83/builds/7271



  C:\PROGRA~2\MICROS~3\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\lldb\source\Utility -IC:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\source\Utility -Itools\lldb\source -IC:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\include -Itools\lldb\include -Iinclude -IC:\buildbot\lldb-x64-windows-ninja\llvm-project\llvm\include -I"C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\include" -IC:\buildbot\lldb-x64-windows-ninja\llvm-project\llvm\..\clang\include -Itools\lldb\..\clang\include -IC:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\source\. /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2 /DNDEBUG   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530  /EHs-c- /GR- -std:c++14 /showIncludes /Fotools\lldb\source\Utility\CMakeFiles\lldbUtility.dir\Timer.cpp.obj /Fdtools\lldb\source\Utility\CMakeFiles\lldbUtility.dir\lldbUtility.pdb /FS -c C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\source\Utility\Timer.cpp
  C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\include\lldb/Utility/Timer.h(49): error C3646: '__attribute__': unknown override specifier
  C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\include\lldb/Utility/Timer.h(49): error C2059: syntax error: '('
  C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\include\lldb/Utility/Timer.h(50): error C2059: syntax error: '('
  C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\include\lldb/Utility/Timer.h(53): error C2143: syntax error: missing ')' before ';'
  C:\buildbot\lldb-x64-windows-ninja\llvm-project\lldb\include\lldb/Utility/Timer.h(53): error C2059: syntax error: ')'

Looks like it's the attribute that it doesn't know about:

  /// Default constructor.
  Timer(Category &category, const char *format, ...)
      __attribute__((format(printf, 3, 4)));


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103575/new/

https://reviews.llvm.org/D103575