[PATCH] D100132: [libunwind][AIX] Initial patch of the unwinder on AIX

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: libunwind/src/assembly.h:63
 
 #if defined(__powerpc64__) && (!defined(_CALL_ELF) || _CALL_ELF == 1)
 #define PPC64_OPD1 .section .opd,"aw", at progbits SEPARATOR
----------------
Should we update the guards so we don't define these macros on AIX?


================
Comment at: libunwind/src/assembly.h:197
+// clang-format off
+#define DEFINE_LIBUNWIND_FUNCTION_AND_WEAKALIAS(name, aliasname)               \
+  .toc SEPARATOR                                                               \
----------------
Minor nit: `_WEAK_ALIAS` to match the other weak alias macros.


================
Comment at: libunwind/src/assembly.h:198
+#define DEFINE_LIBUNWIND_FUNCTION_AND_WEAKALIAS(name, aliasname)               \
+  .toc SEPARATOR                                                               \
+  .globl name SEPARATOR                                                        \
----------------
Same comment as below about this .toc pseudo op.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100132/new/

https://reviews.llvm.org/D100132