[PATCH] D104288: [VP][NFCI] Address various clang-tidy warnings

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

LGTM with nit.



================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:253
     ASSERT_EQ(F.getIntrinsicID(), NewDecl->getIntrinsicID());
-    auto ItNewParams = NewDecl->getFunctionType()->param_begin();
-    auto EndItNewParams = NewDecl->getFunctionType()->param_end();
+    const auto *ItNewParams = NewDecl->getFunctionType()->param_begin();
+    const auto *EndItNewParams = NewDecl->getFunctionType()->param_end();
----------------
I know `const auto*` follows the convention. However, i like just `const auto` here because do we really want to assert the type structure of what is actually just 'some' iterator to us?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104288/new/

https://reviews.llvm.org/D104288