[PATCH] D104247: [DAGCombine] reassoc flag shouldn't enable contract

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov added a comment.

Changes in AMDGPU tests LGTM, thanks!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12875
 
 static bool isContractable(SDNode *N) {
   SDNodeFlags F = N->getFlags();
----------------
Nit: it seems this function is too trivial now and we can remove it?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13110
   const SDNodeFlags Flags = N->getFlags();
   bool CanFuse = Options.UnsafeFPMath || isContractable(N);
   bool AllowFusionGlobally = (Options.AllowFPOpFusion == FPOpFusion::Fast ||
----------------
Nit: move `CanFuse` definition two hundreds lines down to its uses?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104247/new/

https://reviews.llvm.org/D104247