[llvm] 89fa1a3 - [ORC] Fix endianness in manual serialization to match WrapperFunctionUtils.

[Lang Hames via llvm-commits]

Author: Lang Hames
Date: 2021-06-15T21:51:52+10:00
New Revision: 89fa1a3a831f2d46e16ac90dbcc5598c5a00b38c

URL: https://github.com/llvm/llvm-project/commit/89fa1a3a831f2d46e16ac90dbcc5598c5a00b38c
DIFF: https://github.com/llvm/llvm-project/commit/89fa1a3a831f2d46e16ac90dbcc5598c5a00b38c.diff

LOG: [ORC] Fix endianness in manual serialization to match WrapperFunctionUtils.

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/Orc/TPCDebugObjectRegistrar.cpp
    llvm/lib/ExecutionEngine/Orc/TPCEHFrameRegistrar.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/Orc/TPCDebugObjectRegistrar.cpp b/llvm/lib/ExecutionEngine/Orc/TPCDebugObjectRegistrar.cpp
index 5c5533828656..f44edaaece7f 100644
--- a/llvm/lib/ExecutionEngine/Orc/TPCDebugObjectRegistrar.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/TPCDebugObjectRegistrar.cpp
@@ -25,7 +25,8 @@ writeDebugObjectInfo(sys::MemoryBlock TargetMemBlock) {
   ArgBuffer.resize(sizeof(decltype(DebugObjAddr)) +
                    sizeof(decltype(DebugObjSize)));
 
-  BinaryStreamWriter ArgWriter(ArgBuffer, support::endianness::big);
+  // FIXME: Replace manual serializatio with WrapperFunction utility.
+  BinaryStreamWriter ArgWriter(ArgBuffer, support::endianness::little);
   cantFail(ArgWriter.writeInteger(DebugObjAddr));
   cantFail(ArgWriter.writeInteger(DebugObjSize));
 

diff  --git a/llvm/lib/ExecutionEngine/Orc/TPCEHFrameRegistrar.cpp b/llvm/lib/ExecutionEngine/Orc/TPCEHFrameRegistrar.cpp
index 4f901ce6d445..c3b1ac18755b 100644
--- a/llvm/lib/ExecutionEngine/Orc/TPCEHFrameRegistrar.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/TPCEHFrameRegistrar.cpp
@@ -54,9 +54,11 @@ Error TPCEHFrameRegistrar::registerEHFrames(JITTargetAddress EHFrameSectionAddr,
                                             size_t EHFrameSectionSize) {
   constexpr size_t ArgBufferSize = sizeof(uint64_t) + sizeof(uint64_t);
   uint8_t ArgBuffer[ArgBufferSize];
+
+  // FIXME: Replace manual serialization with WrapperFunction util call.
   BinaryStreamWriter ArgWriter(
       MutableArrayRef<uint8_t>(ArgBuffer, ArgBufferSize),
-      support::endianness::big);
+      support::endianness::little);
   cantFail(ArgWriter.writeInteger(static_cast<uint64_t>(EHFrameSectionAddr)));
   cantFail(ArgWriter.writeInteger(static_cast<uint64_t>(EHFrameSectionSize)));
 
@@ -67,9 +69,11 @@ Error TPCEHFrameRegistrar::deregisterEHFrames(
     JITTargetAddress EHFrameSectionAddr, size_t EHFrameSectionSize) {
   constexpr size_t ArgBufferSize = sizeof(uint64_t) + sizeof(uint64_t);
   uint8_t ArgBuffer[ArgBufferSize];
+
+  // FIXME: Replace manual serialization with WrapperFunction util call.
   BinaryStreamWriter ArgWriter(
       MutableArrayRef<uint8_t>(ArgBuffer, ArgBufferSize),
-      support::endianness::big);
+      support::endianness::little);
   cantFail(ArgWriter.writeInteger(static_cast<uint64_t>(EHFrameSectionAddr)));
   cantFail(ArgWriter.writeInteger(static_cast<uint64_t>(EHFrameSectionSize)));