[llvm] 5a28bde - [ORC] Fix missing function in unit test.
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 15 04:39:10 PDT 2021
Author: Lang Hames
Date: 2021-06-15T21:39:00+10:00
New Revision: 5a28bdeeb61a49f71c5a2b3cb5d96ec1f9f3f571
URL: https://github.com/llvm/llvm-project/commit/5a28bdeeb61a49f71c5a2b3cb5d96ec1f9f3f571
DIFF: https://github.com/llvm/llvm-project/commit/5a28bdeeb61a49f71c5a2b3cb5d96ec1f9f3f571.diff
LOG: [ORC] Fix missing function in unit test.
Added:
Modified:
llvm/include/llvm/ExecutionEngine/Orc/Shared/WrapperFunctionUtils.h
llvm/unittests/ExecutionEngine/Orc/WrapperFunctionUtilsTest.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Shared/WrapperFunctionUtils.h b/llvm/include/llvm/ExecutionEngine/Orc/Shared/WrapperFunctionUtils.h
index f6d7c820720c..3385b7ab1062 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Shared/WrapperFunctionUtils.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Shared/WrapperFunctionUtils.h
@@ -410,10 +410,10 @@ template <typename... SPSTagTs>
class WrapperFunction<void(SPSTagTs...)>
: private WrapperFunction<SPSEmpty(SPSTagTs...)> {
public:
- template <typename... ArgTs>
- static Error call(const void *FnTag, const ArgTs &...Args) {
+ template <typename CallerFn, typename... ArgTs>
+ static Error call(const CallerFn &Caller, const ArgTs &...Args) {
SPSEmpty BE;
- return WrapperFunction<SPSEmpty(SPSTagTs...)>::call(FnTag, BE, Args...);
+ return WrapperFunction<SPSEmpty(SPSTagTs...)>::call(Caller, BE, Args...);
}
using WrapperFunction<SPSEmpty(SPSTagTs...)>::handle;
diff --git a/llvm/unittests/ExecutionEngine/Orc/WrapperFunctionUtilsTest.cpp b/llvm/unittests/ExecutionEngine/Orc/WrapperFunctionUtilsTest.cpp
index d93637ea128a..1f177b4c2d14 100644
--- a/llvm/unittests/ExecutionEngine/Orc/WrapperFunctionUtilsTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/WrapperFunctionUtilsTest.cpp
@@ -53,6 +53,8 @@ TEST(WrapperFunctionUtilsTest, WrapperFunctionResultFromOutOfBandError) {
EXPECT_TRUE(strcmp(R.getOutOfBandError(), TestString) == 0);
}
+static void voidNoop() {}
+
static WrapperFunctionResult voidNoopWrapper(const char *ArgData,
size_t ArgSize) {
return WrapperFunction<void()>::handle(ArgData, ArgSize, voidNoop);
@@ -64,7 +66,7 @@ static WrapperFunctionResult addWrapper(const char *ArgData, size_t ArgSize) {
}
TEST(WrapperFunctionUtilsTest, WrapperFunctionCallVoidNoopAndHandle) {
- EXPECT_FALSE(!!WrapperFunction<void()>::call((void *)&voidNoopWrapper));
+ EXPECT_FALSE(!!WrapperFunction<void()>::call(voidNoopWrapper));
}
TEST(WrapperFunctionUtilsTest, WrapperFunctionCallAndHandle) {
More information about the llvm-commits
mailing list