[PATCH] D102535: [RISCV] -mno-relax: emit .option norelax

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 03:43:34 PDT 2021


luismarques added a comment.

In D102535#2811903 <https://reviews.llvm.org/D102535#2811903>, @evandro wrote:

> Methinks that the choice of whether to relax or not should be decided outside of the assembler code.  This directive sets the choice in stone and counters any choice done at build time, when optimizations are specified.  For instance, when building a debug version, the optimizations may be different from when building a release version.  This directive blocks such common practices and may create confusion and non expected results.

I thought I understood your point initially, but now I'm not sure.  Can you clarify what flexibility you're losing? Doesn't the emission of this directive reflect exactly the build settings you specify at compilation time? Why is it important to override this later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102535/new/

https://reviews.llvm.org/D102535



More information about the llvm-commits mailing list