[PATCH] D104282: [FuncSpec] Use std::pow instead of operator^

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Transforms/FunctionSpecialization/function-specialization-loop.ll:2
+; RUN: opt -function-specialization -func-specialization-avg-iters-cost=3 -S < %s | FileCheck %s
+
+; check the bonus for specializing constant arguments are powered by the depth of the loop.
----------------
ChuanqiXu wrote:
> ChuanqiXu wrote:
> > SjoerdMeijer wrote:
> > > Just checking, this test didn't trigger before, and now it does? 
> > > If so, would be good to precommit the test, then we can also see the differences better here.
> > Yeah, I had checked that.
> Do you mean that send a NFC patch which contains the test case only? Then we tried to update this one, is it?
Yeah, I mean committing just the test first, then rebase this on top of that.
But with your confirmation that this now triggers and it didn't before, perhaps that's extra work we don't need, so you can commit this in one go.

This looks like a good fix to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104282/new/

https://reviews.llvm.org/D104282