[PATCH] D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter.

Tue Jun 15 01:54:31 PDT 2021

frasercrmck added a comment.

In D99355#2818618 <https://reviews.llvm.org/D99355#2818618>, @simoll wrote:

> In D99355#2816492 <https://reviews.llvm.org/D99355#2816492>, @frasercrmck wrote:
>
>> Just so I know for the VP reduction intrinsics, should we not be adding LangRef documentation at this stage too, given we're adding new intrinsics? How about support in the `ExpandVectorPredication` pass? Should that come now or can it wait?
>
> Ideally, yes, you want to have the documentation with the intrinsics and their expansion in one patch.
> If that grows too large, you split off the expansion for another patch.
> For this patch, since we are kind of stalling on memory intrinsics to become available upstream, it'd be ok for me to just have the intrinsics and save everything else for followup patches. The intrinsics are documented in the reference implementation anyway.

Got you, thanks for the info. I'd definitely prefer to have it all done in one for my own patches but I'm not going to block this one or anything.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99355/new/

https://reviews.llvm.org/D99355