[PATCH] D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Hi @DylanFleming-arm 
I believe something wrong happened when you uploaded this patch.
It is not showing  LoopVectorize.cpp file. 
I can only see// Context not available.//
Is that happening for you too?



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-trunc-min-bitwidth.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; ModuleID = 'bla2.ll'
+; RUN: opt < %s -loop-vectorize -scalable-vectorization=preferred -S | FileCheck %s
----------------
Remove that


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-trunc-min-bitwidth.ll:3
+; ModuleID = 'bla2.ll'
+; RUN: opt < %s -loop-vectorize -scalable-vectorization=preferred -S | FileCheck %s
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
----------------
Can you make that a more generic test using the flag:
 -force-target-supports-scalable-vectors 
?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-trunc-min-bitwidth.ll:5
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
+target triple = "aarch64-unknown-linux-gnu"
+
----------------
Remove that too.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-trunc-min-bitwidth.ll:106
+
+attributes #0 = { "target-features"="+neon,+sve" }
----------------
I believe you don't need that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104239/new/

https://reviews.llvm.org/D104239