[PATCH] D104119: [IR] Remove forward declaration of GraphTraits from Type.h

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 01:25:41 PDT 2021


foad added a comment.

> though might be worth considering #including "GraphTraits.h" rather than the forward declaration - makes maintenance a bit easier later on, if default template arguments were added to GraphTraits or other changes are made.

I considered and rejected it. I think the LLVM project as a whole prefers forward declarations to #includes, for the sake of build time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104119/new/

https://reviews.llvm.org/D104119



More information about the llvm-commits mailing list