[PATCH] D104282: [FuncSpec] Use std::pow instead of operator^

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 14 23:06:24 PDT 2021


ChuanqiXu created this revision.
ChuanqiXu added reviewers: SjoerdMeijer, fhahn, sanwou01, jaykang10.
Herald added subscribers: ormris, hiraditya.
ChuanqiXu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The original implementation uses operator ^, which means XOR in C++ language.
At the first glance of reviewing, I thought it should be power, my bad.
It doesn't make sense to use XOR here. So I believe it should be a carelessness as I made.

Test Plan: check-all


https://reviews.llvm.org/D104282

Files:
  llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
  llvm/test/Transforms/FunctionSpecialization/function-specialization-loop.ll
  llvm/test/Transforms/FunctionSpecialization/function-specialization-recursive.ll
  llvm/test/Transforms/FunctionSpecialization/function-specialization3.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104282.352048.patch
Type: text/x-patch
Size: 4548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210615/1a27b464/attachment.bin>


More information about the llvm-commits mailing list