[PATCH] D104013: [LangRef] State that the based-on relation is for pointer typed values only

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added inline comments.


================
Comment at: llvm/docs/LangRef.rst:2666
+   in *any* address-space is associated with no address range.
+-  A pointer cast from an integer constant other than zero, a pointer that is
+   cast from zero and its address space does not have a null pointer,
----------------
jdoerfert wrote:
> nhaehnle wrote:
> > Should the "constant" be removed?
> ^ yes. And I would not say `null pointer` but use the wording we have elsewhere: "if a `null` pointer is defined". My worry is that `(void*)0` is always a null pointer, no matter the AS but the AS determines if this has the special or non special meaning.
I updated the sentence by using the wording at the description of 'null_pointer_is_valid' attribute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104013/new/

https://reviews.llvm.org/D104013