[PATCH] D104267: [CSSPGO] Fix an invalid hash table reference issue in the CS preinliner.

[Lei Wang via Phabricator via llvm-commits]

wlei added a comment.

Thanks for the fix!



================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:394
+    auto Ret = ProfilesToBeAdded.try_emplace(ContextStr, FProfile);
+    (void)Ret;
     assert(Ret.second && "Conext conflict during canonicalization");
----------------
Do we need this?


================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:395
+    (void)Ret;
     assert(Ret.second && "Conext conflict during canonicalization");
 
----------------
typo: Context


================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:399
+    assert(!ProfilesToBeRemoved.count(ContextStr) &&
+           "Conext supposed to be removed");
     ProfilesToBeRemoved.insert(I.first());
----------------
typo: Context


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104267/new/

https://reviews.llvm.org/D104267