[PATCH] D104184: [Coroutine] Put byval params' value into frame, instead of just pointer

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroEarly.cpp:224
+      if (A.hasNoAliasAttr())
+        A.removeAttr(Attribute::NoAlias);
   return Changed;
----------------
Hmm...

It might make sense to fix this in clang, rather than here, but I guess this is okay?


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1605
+          Builder.CreateLoad(Def->getType()->getPointerElementType(), Def);
+      Builder.CreateStore(Value, G);
+    } else {
----------------
Use memcpy to copy large values; load+store results in very inefficient code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104184/new/

https://reviews.llvm.org/D104184