[PATCH] D18490: [PGO] Comment how function pointers for indirect calls are mapped to function names

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/trunk/include/llvm/ProfileData/InstrProfData.inc:78
+// function name hashes during the conversion from raw to merged profile data.
 INSTR_PROF_DATA(const IntPtrT, llvm::Type::getInt8PtrTy(Ctx), FunctionPointer, \
                 FunctionAddr)
----------------
MaskRay wrote:
> Is `FunctionPointer` still used by the runtime? @davidxl @vsk 
> 
> I can only find one reference `__llvm_get_function_addr`, which is a public API.
Hmm. It is used by `ProfileData/InstrProfReader.cpp`

So it seems that value profiling adds quite a bit size overhead to the metadata sections.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D18490/new/

https://reviews.llvm.org/D18490