[PATCH] D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 14 16:09:07 PDT 2021


aeubanks added a comment.

maybe we should make a quick post on llvm-dev about this to see what other people think, since this will be very user-visible



================
Comment at: llvm/lib/IR/Verifier.cpp:1843
+    // Skip opaque pointer.
+    if (PTy->isOpaque())
+      return;
----------------
we still want some of the checks below, for example, we want to check `!Attrs.getByValType()->isSized()`
perhaps we should separate this out into a separate change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104272/new/

https://reviews.llvm.org/D104272



More information about the llvm-commits mailing list