[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 14 16:04:16 PDT 2021


On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator <
reviews at reviews.llvm.org> wrote:

> lebedev.ri added a subscriber: MaskRay.
> lebedev.ri added a comment.
>
> In D104099#2815531 <https://reviews.llvm.org/D104099#2815531>, @wenlei
> wrote:
>
> > In D104099#2814167 <https://reviews.llvm.org/D104099#2814167>, @davidxl
> wrote:
> >
> >> Adding Wei to help measure performance impact on our internal
> workloads.  Also add Wenlei to help measure impact with FB's workloads.
> >
> > Measured perf using FB internal workload w/ and w/o this pass, result is
> neutral.
>
> Thank you for checking!
>
> So far, it seems the reaction to this proposal has been overwhelmingly
> positive.
> Does anyone else wish to chime in? Should i land this? @asbirlea @MaskRay ?
>

Wei is doing more measurement @google. Please wait for the response.

David


>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D104099/new/
>
> https://reviews.llvm.org/D104099
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210614/dcfca925/attachment.html>


More information about the llvm-commits mailing list