[PATCH] D103316: Hoist llvm.assume into single predecessor if block otherwise empty

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D103316#2817597 <https://reviews.llvm.org/D103316#2817597>, @jdoerfert wrote:

> I thought the problem was that a block with an assume caused us to miss out on some backed optimization.
> The proposed solution was to eliminate blocks that only contain an assume as side effect early as middle-end
> optimizations would also benefit from a simplified CFG.

The problem @markus is working on is that the assumes are removed already in CodeGenPrepare. So there is no assumes left in the IR after CodeGenPrepare, and any AliasAnalysis queries after CodeGenPrepare won't benefit from the assumes.
Thus, any guidance here that isn't moving towards the goal of handling assumes better in CodeGenPrepare (preferrably keeping/salvaging as many assumes as possible) is a bit confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103316/new/

https://reviews.llvm.org/D103316