[PATCH] D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFFObjectFile.h:36
   IndexedMap<const uint8_t *> EsdPtrs; // Indexed by EsdId.
+  SmallVector<const uint8_t *, 256> TextPtrs;
 
----------------
jhenderson wrote:
> Any particular reason you've chosen the size 256 here and in various other places? It may deserve a comment or some sort of named constant.
An initial vector size of 256 guarantees that in most cases the vector does not need to be extended, and avoids a memory allocation in SmallVector. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103490/new/

https://reviews.llvm.org/D103490