asbirlea added a comment. I will second @fhahn's comments. Please include follow up patches with the improvements you mention, and tests that motivate those. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104180/new/ https://reviews.llvm.org/D104180