[PATCH] D104123: [llvm][AArch64] Handle arrays of struct properly (from IR)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 14 11:42:42 PDT 2021


efriedma added a comment.

Seems fine to me.  An alternative implementation could use ComputeValueVTs, instead of implementing the recursion yourself, but this seems okay as-is.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17120
+    // Walk all the sub types of this aggregate
+    auto subtypes_end = Ty->subtype_end();
+    for (Type *SubTy : Ty->subtypes()) {
----------------
Unused variable subtypes_end


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104123/new/

https://reviews.llvm.org/D104123



More information about the llvm-commits mailing list