[PATCH] D104169: [lld-macho][nfc] Put back shouldOmitFromOutput() asserts

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:177
     if (auto *referentIsec = r.referent.dyn_cast<InputSection *>()) {
+      assert(!shouldOmitFromOutput(referentIsec));
       // Personality functions can be referenced via section relocations
----------------
thakis wrote:
> Hm, is this correct? See the FIXME at the start of the loop. It's correct to assert that this isn't a coalesced weak, but it might be a non-live symbol I think. (But not sure.)
good point -- I've switched it back to use `isCoalescedWeak()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104169/new/

https://reviews.llvm.org/D104169