[PATCH] D103378: [VectorCombine] Freeze index unless it is known to be non-poison.

Mon Jun 14 08:48:05 PDT 2021

fhahn added inline comments.

================
Comment at: llvm/test/Transforms/VectorCombine/AArch64/load-extractelement-scalarization.ll:153
+; CHECK-NEXT:    [[R:%.*]] = load i32, i32* [[TMP1]], align 4
 ; CHECK-NEXT:    ret i32 [[R]]
 ;
----------------
efriedma wrote:
> This is still not right.  See https://alive2.llvm.org/ce/z/dqg8HF
Thanks Eli, I thought I ran Alive2 on the test after the changes but something went wrong. I limited the transform to non-poison indices only for now in 96ca03493ae5.

Not sure if there's much else we can do to make this save using freeze, if we cannot rely on the constrained range.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103378/new/

https://reviews.llvm.org/D103378