[PATCH] D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions.

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:447
+
+    for (Instruction &Val : *CurrBB) {
+      if (CallInst *CI = dyn_cast<CallInst>(&Val)) {
----------------
djtodoro wrote:
> can we use some early exits here?
I've reversed the logic so that we check for not a call instruction first, then act on that to decrease the indentation.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:468
+     // Remove the debug information for outlined functions.
+     Val.setDebugLoc(DebugLoc());
+    }
----------------
djtodoro wrote:
> Is this clang-formatted?
Most of it is, but this crept in under the radar


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87302/new/

https://reviews.llvm.org/D87302