[PATCH] D104102: Function Specialisation, cont'd

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for the update! Could you update the description/title, as they seem a bit out-of-sync after the recent changes.



================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:124
+
+    NumFuncSpecialized += FunctionsSpecialized;
     return Changed;
----------------
might be good to also have a test to check the stats work as expected?


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:146
 private:
+  int FunctionsSpecialized = 0;
+
----------------
Would be good to add a comment. Should the type be `unsigned`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104102/new/

https://reviews.llvm.org/D104102