[PATCH] D99173: Intrinsic::getName: require a Module argument
Jeroen Dobbelaere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 14 05:51:25 PDT 2021
jeroen.dobbelaere marked 3 inline comments as done.
jeroen.dobbelaere added a comment.
Thanks for the review and the feedback !
================
Comment at: llvm/lib/IR/Function.cpp:870
if (!FT)
- FT = getType(M->getContext(), Id, Tys);
+ FT = Intrinsic::getType(M->getContext(), Id, Tys);
else
----------------
nikic wrote:
> Why do we need the `Intrinsic::` prefix now? Just a style change?
This now is a file local static function and we need the explicit `Intrinsic::` to access the getType(...) method.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99173/new/
https://reviews.llvm.org/D99173
More information about the llvm-commits
mailing list