[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

[Bradley Smith via Phabricator via llvm-commits]

bsmith added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:386-388
+  if (MaxSVEVectorSizeInBits == 0)
+    return (MinSVEVectorSizeInBits / 128) * 128;
+  return (std::min(MinSVEVectorSizeInBits, MaxSVEVectorSizeInBits) / 128) * 128;
----------------
paulwalker-arm wrote:
> Based on my other comments I'm wondering if we just got to the point where both these functions need to be moved into `AArch64TargetMachine.cpp` with `AArch64Subtarget` having simple accessors.
I don't think we can go quite this far as AArch64TargetMachine is not function specific like the attributes are. I think we can move all of the logic of resolving between the options and the attribute, but the storage/accessors for the resulting value needs to live in the subtarget.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103702/new/

https://reviews.llvm.org/D103702