[PATCH] D104200: [lld-macho][nfc] Add `final` to classes where possible

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 14 00:30:23 PDT 2021


grandinj added a comment.

I did this (for LibreOffice), and final seems to be only a win when we do LTO and we can de-virtualise a bunch of stuff.

I was hoping that final would also help for dynamic_cast (where, in theory, if we're casting to a final type, we can optimise to a simple comparison), but that doesn't seem to be impemented by the dynamic_cast machinery (or the compiler)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104200/new/

https://reviews.llvm.org/D104200



More information about the llvm-commits mailing list