[PATCH] D103655: [AMDGPU] Handle constant LDS uses from different kernels

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 10:25:18 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:36
+                                SetVector<Instruction *> &InstUsers) {
+  SmallVector<User *> Stack({U});
+
----------------
hsmhsm wrote:
> Not sure. what is the reall difference between SmallVector<User *> Stack({U}); and SmallVector<User *> Stack{U};
No real difference except that I am not using c++11 syntax. Let's go in style and save couple symbols anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103655/new/

https://reviews.llvm.org/D103655



More information about the llvm-commits mailing list