[PATCH] D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions.
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 13 23:46:26 PDT 2021
djtodoro added a comment.
the tests look good to me now, thanks! (some nits included)
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:447
+
+ for (Instruction &Val : *CurrBB) {
+ if (CallInst *CI = dyn_cast<CallInst>(&Val)) {
----------------
can we use some early exits here?
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:468
+ // Remove the debug information for outlined functions.
+ Val.setDebugLoc(DebugLoc());
+ }
----------------
Is this clang-formatted?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87302/new/
https://reviews.llvm.org/D87302
More information about the llvm-commits
mailing list