[PATCH] D104194: Fix misspelled instruction in X86 assembly parser

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 13 15:20:04 PDT 2021


epastor added a comment.

In D104194#2815762 <https://reviews.llvm.org/D104194#2815762>, @MaskRay wrote:

> More concretely, branch instruction tests in `llvm/test/MC/X86/x86-32.s` can be moved outside, then you can add a test for jecxz. jexcz seems untested.

Thanks for the concrete feedback! I couldn't figure out where the tests for this were. It looks like the "jcc short" family is all tested in intel-syntax.s, so I've added it there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104194/new/

https://reviews.llvm.org/D104194



More information about the llvm-commits mailing list