[PATCH] D104142: [IROutliner] Ensure instructions at end of candidate are excluded

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1583
       OS->splitCandidate();
+      if (OS->IgnoreRegion)
+        continue;
----------------
hiraditya wrote:
> Do we need to split when the region is going to be ignored?
There's a chance that when the region is split, extra instructions are added changing the possibility of outlining, and it is no longer viable to be split.  It might be better to have this function return a boolean if it has been split, or has not been, then continue based on that result.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104142/new/

https://reviews.llvm.org/D104142